London | ITP May 25 | Lahlah Houssam | Sprint 2 | Coursework#698
London | ITP May 25 | Lahlah Houssam | Sprint 2 | Coursework#698HoussamLh wants to merge 27 commits intoCodeYourFuture:mainfrom
Conversation
…dle, and last names.
…om file path string using slice.
…ween minimum and maximum.
Moved padStart(2, "0") to a single location after calculating rawHour. Improves readability and makes the function easier to maintain. Thanks for the helpful suggestion!
HoussamLh
added
the
Needs Review
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
I had reviewed and mark your work as "Complete" in the previous cohort. There seems to be an issue in your PR title. Can you address this issue so that I can mark this PR as complete? |
cjyuan
added
Reviewed
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
HoussamLh
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 participants
Self checklist
Changelist
This pull request for syn my fork and updating my branch.
Questions
Please, Let me know if there is anything else went wrong?