London | ITP-May-2025 | Surafel Workneh | Structuring and testing data | acoursework/sprint 2#647
Closed
SuWebOnes wants to merge 34 commits intoCodeYourFuture:mainfrom
Closed
London | ITP-May-2025 | Surafel Workneh | Structuring and testing data | acoursework/sprint 2#647SuWebOnes wants to merge 34 commits intoCodeYourFuture:mainfrom
SuWebOnes wants to merge 34 commits intoCodeYourFuture:mainfrom
Conversation
…pdate comments for clarity Sprint-2/1-key-errors/0.js
…xplain Sprint-2/1-key-errors/1.js
… parameter definition and error explanation in Sprint-2/1-key-errors/2.js
…d explain function for clarity in Sprint-2/2-mandatory-debug/0.js
… return the sum of two numbers and explain code for clarity in Sprint-2/2-mandatory-debug/1.js
…x getLastDigit function to correctly return the last digit of a number and update comments for clarity in Sprint-2/2-mandatory-debug/2.js
…hy it always returns '3' in Sprint-2/2-mandatory-debug/2.js
…sed on weight and height, including detailed comments for clarity in Sprint-2/3-mandatory-implement/1-bmi.js
…KE_CASE with example usage Sprint-2/3-mandatory-implement/2-cases.js
…tted pounds with example usage Sprint-2/3-mandatory-implement/3-to-pounds.js
…d pad() in sprint -2/ time-format.js
…ps of input data or edge cases as you can, and fix any bugs in Sprint-2/5-stretch-extend/format-time.js
…add tests for zero numerator and denominator
…, and invalid inputs with corresponding tests
…roper angle classification with consolelog
…larity and readability
…s for numerator and denominator, ensuring proper fraction validation
… and add test cases
…ive integer counts
…clarity on loop mechanics
London | May-2025 | Surafel Workneh | Acoursework/sprint 2
SuWebOnes
added
the
Needs Review
SuWebOnes
changed the title
SuWebOnes
changed the title
cjyuan
added
👀 Review Git
Reviewed
cjyuan
reviewed
Jul 17, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The modified files on this branch are the files in "Sprint-3" folder. There is not modified files in the "Sprint-2" folder.
Author
|
@cjyuan I incorrectly create PR for my self and closed it and Reverted to get the changes that is why " from [SuWebOnes:revert-2-acoursework/sprint-2 is from 'revert-2-acoursework/sprint-2) ' " description written |
Author
|
Author
|
in my repo it will show the changes inside the file! I didn't understand your comment. please can you explain it more please? |
Contributor
|
Click the "Files changed" tab to see which files are different (when compared to the the files in CYF's I expected to see only changed files in the "Sprint-2" folder for Sprint-2 PR. |
Author
|
good Afternoon CJ, I was discussed with volunteer and I rebase and created this new PR pleasehttps://github.com//pull/667 |
Contributor
|
I will review your PR 667. You can close this one. |
cjyuan
removed
👀 Review Git
Reviewed
Author
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
The following are main Change-lists
Fixed variable redeclaration errors in test blocks and functions.
Corrected logic in math functions like sum, square, and multiply.
Added utility functions: calculateBMI, toUpperSnakeCase, and toPounds.
Explained function outputs for better clarity (e.g., formatTimeDisplay).
Added tests for formatAs12HourClock to cover key edge cases like midnight, noon, and late hours.