-
-
Notifications
You must be signed in to change notification settings - Fork 391
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | Coursework sprint 3 practice tdd #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tobias-Amaechina
wants to merge
17
commits into
CodeYourFuture:main
Choose a base branch
from
Tobias-Amaechina:coursework-sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
281d67a
installed package.json and package.lock.json
Tobias-Amaechina c22490e
Wrote a test to pass the count.tes.js and update package.json
Tobias-Amaechina fd74c90
Wrote a test suite to check for no occurance
Tobias-Amaechina b2d0d65
Wrote a test case to pass the first set of conditions
Tobias-Amaechina 5f543ef
Implement a condition in the function to handle everything thet ends …
Tobias-Amaechina c645b53
wrote test case to pass when number ends in 11, 12 and 13
Tobias-Amaechina 5481fb4
wrote a test case for number ending in 12 and 13
Tobias-Amaechina 340c19f
implement a condition to pass number ending in 2 as nd
Tobias-Amaechina 7e5f8ee
implemented a condition to pass numers ending in 3 but not 13
Tobias-Amaechina eb5da76
implement a function to pass the dynmaict repeat of function
Tobias-Amaechina baaf08d
wrote a test case to check for dynamic count of str i time
Tobias-Amaechina f510445
console log with count 1 time and noticed the output equls 1 time
Tobias-Amaechina fd06505
wrote a test case for count equal to 0 to return empty string
Tobias-Amaechina 8767246
printed the output of empty string when count is zero
Tobias-Amaechina 8b6b488
wrote a test case to throw and error for negtive count
Tobias-Amaechina 3eec672
wrote a functione condition to handle test case for negative count
Tobias-Amaechina 4ab8301
fixed the error in get-ordinal-number.test.js
Tobias-Amaechina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,17 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const lastDigit = num % 10; | ||
| const lastTwoDigits = num % 100; | ||
|
|
||
|
|
||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return `${num}th`; | ||
| } | ||
|
|
||
| if (lastDigit === 1) return `${num}st`; | ||
| if (lastDigit === 2) return `${num}nd`; | ||
| if (lastDigit === 3) return `${num}rd`; | ||
| return `${num}th`; | ||
| } | ||
|
|
||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,72 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" | |
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| }); | ||
|
|
||
| // Case 2: Numbers ending with 11 | ||
| // When the number ends with 11, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for numbers ending with 11", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(111)).toEqual("111th"); | ||
| expect(getOrdinalNumber(211)).toEqual("211th"); | ||
| expect(getOrdinalNumber(311)).toEqual("311th"); | ||
| }); | ||
|
|
||
| // Case 3 numbers ending in 12 and 13 | ||
| test("should append 'th' for numbers ending with 12 and 13", () => { | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| expect(getOrdinalNumber(112)).toEqual("112th"); | ||
| expect(getOrdinalNumber(113)).toEqual("113th"); | ||
| }); | ||
|
|
||
| // case 4: Numbers ending with 2 (but not 12) | ||
| // When the number ends with 2, except those ending with 12, | ||
| // Then the function should return a string by appending "nd" to the number. | ||
| test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(32)).toEqual("32nd"); | ||
| }); | ||
|
|
||
| // Case 5: Numbers ending with 3 (but not 13) | ||
| // When the number ends with 3, except those ending with 13, | ||
| // Then the function should return a string by appending "rd" to the number. | ||
| test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(33)).toEqual("33rd"); | ||
| }); | ||
|
|
||
| // Case 6: All other numbers | ||
| // When the number does not fall into any of the above categories, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for all other numbers", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to. Could you revise the test description to make it more informative? |
||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(5)).toEqual("5th"); | ||
| expect(getOrdinalNumber(6)).toEqual("6th"); | ||
| expect(getOrdinalNumber(7)).toEqual("7th"); | ||
| expect(getOrdinalNumber(8)).toEqual("8th"); | ||
| expect(getOrdinalNumber(9)).toEqual("9th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(14)).toEqual("14th"); | ||
| expect(getOrdinalNumber(15)).toEqual("15th"); | ||
| expect(getOrdinalNumber(16)).toEqual("16th"); | ||
| expect(getOrdinalNumber(17)).toEqual("17th"); | ||
| expect(getOrdinalNumber(18)).toEqual("18th"); | ||
| expect(getOrdinalNumber(19)).toEqual("19th"); | ||
| expect(getOrdinalNumber(20)).toEqual("20th"); | ||
| expect(getOrdinalNumber(24)).toEqual("24th"); | ||
| expect(getOrdinalNumber(25)).toEqual("25th"); | ||
| expect(getOrdinalNumber(26)).toEqual("26th"); | ||
| expect(getOrdinalNumber(27)).toEqual("27th"); | ||
| expect(getOrdinalNumber(28)).toEqual("28th"); | ||
| expect(getOrdinalNumber(29)).toEqual("29th"); | ||
| expect(getOrdinalNumber(30)).toEqual("30th"); | ||
| }); | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing a few more samples in this script - higher chance to detect bugs in code.
Also, the original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,