Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewrite tests#1486
Open
Abduhasen wants to merge 2 commits into
Open
Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewrite tests#1486Abduhasen wants to merge 2 commits into
Abduhasen wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Abduhasen
added
📅 Sprint 3
Abduhasen
changed the title
Abduhasen
force-pushed
the
Sprint-3-Backlog
branch
from
July 12, 2026 18:54
3167d4f to
9091cac
Compare
cjyuan
reviewed
Jul 17, 2026
Comment on lines
+16
to
+20
| } else if (denominator === 0) { | ||
| return false; | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Code on lines 16-20 could further be simplified.
|
|
||
| function getCardValue(card) { | ||
| // TODO: Implement this function | ||
| const validRank = [ |
Contributor
There was a problem hiding this comment.
It's common practice to use plural names for arrays.
Comment on lines
+21
to
+23
| return "Right angle"; | ||
| } else if (90 < angle && angle < 180) { | ||
| return "Obtuse angles"; |
Contributor
There was a problem hiding this comment.
Should some in singular form and some in plural form?
| expect(getAngleType(-2)).toEqual("Invalid angles"); | ||
| expect(getAngleType(361)).toEqual("Invalid angles"); | ||
| expect(getAngleType(890)).toEqual("Invalid angles"); | ||
| }); |
Contributor
There was a problem hiding this comment.
-
Could consider explicitly specify the range of the invalid angles in the test description.
-
Why not test the boundary cases?
cjyuan
reviewed
Jul 17, 2026
Comment on lines
+11
to
+17
| test(`should return false when the denominator less nominator`, () => { | ||
| expect(isProperFraction(7, 2)).toEqual(false); | ||
| expect(isProperFraction(-17, -2)).toEqual(false); | ||
| expect(isProperFraction(0.5, 0.1)).toEqual(false); | ||
| }); | ||
| test(`should return true when denominator is greater than nominator`, () => { | ||
| expect(isProperFraction(2, 8)).toEqual(true); |
Contributor
There was a problem hiding this comment.
-
The test description applies only when the values being compared are the absolute values of the denominator and numerator. You could consider using pseudo-code and notations like
abs(...)or| ... |to denote absolute value in the test description. -
Why not test the boundary cases?
Note: The correct term is numerator (not nominator).
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR implements the required function and updates the related tests to match the new implementation.
Questions
N/A