Glasgow | ITP-MAY-2026 | Tuan Nguyen | Sprint 1 | Programming-fundamentals#1307
Open
Jacknguyen4438 wants to merge 19 commits into
Open
Glasgow | ITP-MAY-2026 | Tuan Nguyen | Sprint 1 | Programming-fundamentals#1307Jacknguyen4438 wants to merge 19 commits into
Jacknguyen4438 wants to merge 19 commits into
Conversation
…Jacknguyen4438/Module-Structuring-and-Testing-Data-ITP-Jan-2026 into programming-funamental-sprint-1
Jacknguyen4438
added
📅 Sprint 2
Author
|
Hello to whom may concern with this PR this is course work that I have finished before hand and ready to be re review if I need to make some change please let me know. |
This was referenced May 6, 2026
Jacknguyen4438
added
📅 Sprint 1
illicitonion
added
Review in progress
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, but a few small things to fix up
|
|
||
| const dir = ; | ||
| const ext = ; | ||
| const dirDirectory = filePath.slice(1,filePath.lastIndexOf("/")); |
Member
There was a problem hiding this comment.
The directory actually includes the leading / - can you fix this?
|
|
||
| /* | ||
| Answer | ||
| a)In this program there are 5 variable declarations: |
Member
There was a problem hiding this comment.
I think you may have missed one - can you spot it?
| - console.log(result); at line 10 | ||
|
|
||
| c)At the line 3 we can see the the expression movieLength % 60, | ||
| what is represent is the reminder value after the division movieLength(in second) value by 60%; |
Member
There was a problem hiding this comment.
Suggested change
| what is represent is the reminder value after the division movieLength(in second) value by 60%; | |
| what is represent is the reminder value after the division movieLength(in second) value by 60 |
| this is to remind how much left over second left in the movie. | ||
|
|
||
| d)In line 4, the the expression that is assigned to totalMinutes | ||
| represent the value after the math operation if movieLength value and remainingSeconds then divine by 60; |
Member
There was a problem hiding this comment.
This doesn't quite make sense as a sentence, and also has a few typos - can you try to rewrite it?
| represent the value after the math operation if movieLength value and remainingSeconds then divine by 60; | ||
|
|
||
| e)For the variable result it represent the combine total time length of the movie in hour/minutes/second template, for better name for this variable | ||
| I would to rename it to formattedMovieDuration. |
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Hell I this is my work that I have done and ready for resubmission.
Questions
No Question.