Glasgow | ITP-May-26 | Alasdair MacDonald | Sprint 3 | Coursework 3 implement and rewrite#1298
Open
MacDonald91 wants to merge 7 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
MacDonald91
added
the
Needs Review
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looks good - just one thing to think about
| // Examples: | ||
| assertEquals(getCardValue("9♠"), 9); | ||
| // Number cards | ||
| const validNumbers = ["2","3","4","5","6","7","8","9","10"]; |
Member
There was a problem hiding this comment.
This works but involves writing down a lot of numbers, and it would be hard to spot if any numbers in the middle aren't valid (e.g. if 7 wasn't valid) - can you think how to write this check in a more expressive way?
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
resubmission.
Questions
n/a