Skip to content

London | ITP-Jan-26 | Mohsen Zamani | Sprint 1 | Coursework#949

Open
mohsenzamanist wants to merge 1 commit intoCodeYourFuture:mainfrom
mohsenzamanist:feature/sprint-1
Open

London | ITP-Jan-26 | Mohsen Zamani | Sprint 1 | Coursework#949
mohsenzamanist wants to merge 1 commit intoCodeYourFuture:mainfrom
mohsenzamanist:feature/sprint-1

Conversation

@mohsenzamanist
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed tasks of Sprint 1: fix, implement, refactor, stretch folders

Questions

  1. While creating the tests, deleted some of the comments explaining what each test should do, because the description on each test was self-explanatory. Is it a good practice or the original comments must stay?
  2. What is the best practice to add comments? When do comments must be added?

@mohsenzamanist mohsenzamanist added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant