London | 25-ITP-Sept | Gislaine Della Bella | Sprint 2 | Sprint 2 -Final by Della-Bella · Pull Request #933 · CodeYourFuture/Module-Data-Groups

Della-Bella · 2025-12-16T07:42:05Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Hi Volunteer,

Please ignore my first commits on this PR. I have tried to clean it up, but for some reason, it is not working, and I will go back to it.

The commits to be revised here are from 'Commits on Dec 16, 2025 - Sprint 2- Lookup.js' "d7ce32bf522dd240741bac5ce9bfc5cc6845e3ae".

Please ignore my first comments on this PR. I have tried to clean but for some reason it is not working, and I will go back to it.

The commits to be revised here are from Commits on Dec 16, 2025 - Sprint 2- Lookup.js
"d7ce32bf522dd240741bac5ce9bfc5cc6845e3ae"

thank you for yout time

// It is not my solution I got help with AI. I confess I need to undestand more those 3 methodos to think how to get to this. // I will come back to it later. For now i will keep practicing more katas because they are help me.

github-actions · 2025-12-16T07:42:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-12-16T07:42:36Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-12-17T03:57:29Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

illicitonion · 2025-12-19T14:47:51Z

Sprint-2/implement/contains.js

@@ -1,3 +1,11 @@
-function contains() {}
+function contains(someObject, propertyName) {
+  let whatTheRobotFound = someObject[propertyName];


What's this variable for?

I realize now that I’m not actually using this variable, so I’ll remove it to keep the code clean.

illicitonion · 2025-12-19T14:49:17Z

Sprint-2/implement/contains.js

-function contains() {}
+function contains(someObject, propertyName) {
+  let whatTheRobotFound = someObject[propertyName];
+  if (someObject[propertyName] === undefined) {


We can store the value undefined in objects. What would you expect to be returned in this case? What does your code do?

contains({"name": undefined}, "name");

I see...my code returns false even if the property exists but is set to undefined. I’ll use the in operator to fix this so it checks for the property instead of its value

illicitonion · 2025-12-19T14:50:19Z

Sprint-2/implement/contains.js

+function contains(someObject, propertyName) {
+  let whatTheRobotFound = someObject[propertyName];
+  if (someObject[propertyName] === undefined) {
+    return false;


You should never have to write:

if (something) { return true; } else { return false; }

Because the condition in an if statement evaluates to a boolean, you can just return it directly:

return something;

which does the same. If you need to negate it, you can

return !something;

illicitonion · 2025-12-19T14:51:14Z

Sprint-2/implement/contains.test.js

 // Then it should return false
-test.todo("contains on empty object returns false");
+test("contains on empty object returns false", () => {
+  const inputEmpty = [];


This isn't an empty object, it's an array. It may be interesting to test what happens when passed an array, but it's not quite what the test name describes.

I used the symbol for an array [] by mistake. I’ll change it to {}

illicitonion · 2025-12-19T14:52:11Z

Sprint-2/implement/contains.test.js

+test("give a object with proprieties when pass contains with non-exist proprity name it should return false", () => {
+  const inputProprieties2 = ["f", "g", "h"];
+  const result = contains(inputProprieties2);
+  expect(result).toEqual(false);
+});


I'm not quite sure what this test description is trying to convey, or what the test is trying to test... Can you explain?

I meant to pass an object (like {a: 1}) and a property name to check if it exists. I error used an array instead

illicitonion · 2025-12-19T14:56:25Z

Sprint-2/implement/contains.test.js

+  const invalidParameters = ("f", "g", "h");
+  const result = contains(invalidParameters);


Not specifying a second parameter is an interesting case here, but the test name isn't very descriptive of this... Also, what is the type of invalidParameters here?

It is a string. Because I used () instead of square brackets, JavaScript only looks at the last item. I also forgot the second parameter. I’ll fix it to be a proper test

illicitonion · 2025-12-19T14:58:47Z

Sprint-2/implement/lookup.js

+  for (let i = 0; i < countryCurrencyPairs.length; i++) {
+    const countryCode = countryCurrencyPairs[i][0];


This works, but probably isn't the most clear way of iterating across this array.

Can you think how other looping constructs, or destructuring, could help you make this more clear and easy to read?

i ffor...of loop would work better there.

illicitonion · 2025-12-19T15:01:50Z

Sprint-2/implement/querystring.test.js

+  expect(parseQueryString("equation=x=y+1")).toEqual({ equation: "x=y+1" });
+});
+
+// Special characters


What's special about %20?

It’s the code for a space

illicitonion · 2025-12-19T15:03:02Z

Sprint-2/interpret/invert.js

 // a) What is the current return value when invert is called with { a : 1 }
+// 1 

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+///2


I don't think the function currently returns numbers. Can you talk through why you think it does?

I was looking at the values inside the object instead of the object I see now that invert should return a new object with keys and values swapped, like { 1: 'a' } instead of just the number 1..

illicitonion · 2025-12-19T15:03:35Z

Sprint-2/interpret/invert.js


 // d) Explain why the current return value is different from the target output
-
+// The bug is invertedObj.key = value — this literally creates a property named "key" 


Good identification of the problem and the fix!

illicitonion · 2025-12-19T15:06:24Z

Your self-checklist isn't currently correctly filled out - you need to tick boxes with [x] with no spaces around the x.

On the first commits - you should be able to remove with any of:

git rebase -i (see https://mlops.systems/posts/2023-04-28-removing-git-commits.html)
git revert git-commit (replacing git-commit with each git commit hash you want to remove, one at a time, starting from the newest one you want to undo)
Creating a new branch from main, and git cherry-pick git-commit (replacing git-commit with each git commit hash that you want to keep, one at a time, starting from the oldest one you want to keep) - if you do this, you'll need to create a new PR from that branch, and close this one.

Della-Bella · 2025-12-21T18:28:57Z

thnk you Daniel for your time

Della-Bella added 12 commits October 28, 2025 22:46

Max Excercise

4938239

Sum Excercise

0d9e98c

Dedupe Excercise

b647f3a

Includes Excercise

6cdb275

Ignore this Commit

8ad77a6

// It is not my solution I got help with AI. I confess I need to undestand more those 3 methodos to think how to get to this. // I will come back to it later. For now i will keep practicing more katas because they are help me.

Contains/ test / Excercise

95f9e07

Deletes additions excercises from other branch

2ece854

New/ Contains Excercise

9285ca4

Corrected Code Format and Declarations Const/ Lets

96d1d84

Sprint 2- Lookup.js

d7ce32b

Excercises Sprint 2- querry String / Tally

f110f2c

Invert Excercise

3c56ceb

Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 16, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 16, 2025

Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025

Della-Bella changed the title ~~Sprint 2 done. New implement/ interpret~~ London | 25-ITP-Sept | Gislaine Della Bella | Sprint 2 | Sprint 2 -Final Dec 17, 2025

Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025

Della-Bella mentioned this pull request Dec 17, 2025

LONDON | Data groups | GISLAINE DELLA BELLA Della-Bella/25--ITP--PLANER#147

Open

illicitonion added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 19, 2025

illicitonion reviewed Dec 19, 2025

View reviewed changes

illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 19, 2025

illicitonion closed this Jan 7, 2026

		const invalidParameters = ("f", "g", "h");
		const result = contains(invalidParameters);

		for (let i = 0; i < countryCurrencyPairs.length; i++) {
		const countryCode = countryCurrencyPairs[i][0];


		// d) Explain why the current return value is different from the target output

		// The bug is invertedObj.key = value — this literally creates a property named "key"

Uh oh!

Conversation

Della-Bella commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

illicitonion commented Dec 19, 2025

Uh oh!

Della-Bella commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Della-Bella commented Dec 16, 2025 •

edited

Loading