NW | 25-ITP-Sep | TzeMing Ho | Sprint 1 | sprint-1-exercises#792
Closed
TzeMingHo wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
NW | 25-ITP-Sep | TzeMing Ho | Sprint 1 | sprint-1-exercises#792TzeMingHo wants to merge 7 commits intoCodeYourFuture:mainfrom
TzeMingHo wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
TzeMingHo
added
Needs Review
CameronDowner
left a comment
CameronDowner
left a comment
There was a problem hiding this comment.
Looking really good - I've left some more challenging question
I will mark as complete & this is done - but if you can answer these I think it will be a good challenge 🙂
| } | ||
|
|
||
| // return [] if arr is [] | ||
| if (arr.length === 0) return []; |
| // return [] if arr is [] | ||
| if (arr.length === 0) return []; | ||
|
|
||
| return [...new Set(arr)]; |
There was a problem hiding this comment.
What's special about Set that solves our problem here?
| test("given an array with no duplicates, it returns the original array", () => { | ||
| expect(dedupe(["a", "b", "c"])).toEqual(["a", "b", "c"]); | ||
| expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]); | ||
| expect(dedupe([{ key1: "a" }, { key2: "b" }, { key3: "c" }])).toEqual([ |
There was a problem hiding this comment.
challenge: what would you expect if I did this?
dedupe([{ key1: "a" }, { key1: "a" }, { key1: "a" }])| return 0; | ||
| } | ||
|
|
||
| return elements.reduce((acc, num) => acc + num, 0); |
There was a problem hiding this comment.
Could you explain what this reduce function is doing?
CameronDowner
added
Complete
jayshreehajgude2012
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have created a function for finding the median, both tests and functions in the implement exercise, refactored the loop function, and found out the frequency of time travel.