Glasgow | May-2025 | Mansoor Munawar | Sprint 3 | Quote generator#767
Closed
MansoorM11 wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
Glasgow | May-2025 | Mansoor Munawar | Sprint 3 | Quote generator#767MansoorM11 wants to merge 4 commits intoCodeYourFuture:mainfrom
MansoorM11 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
MansoorM11
added
the
Needs Review
sambabib
added
Review in progress
sambabib
reviewed
Aug 15, 2025
Sprint-3/quote-generator/index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="./style.css" /> | ||
| <title>Title here</title> |
There was a problem hiding this comment.
minor feedback, but you have not updated the title of the application per the instructions. it's a minor detail so please update that.
sambabib
reviewed
Aug 15, 2025
| <div> | ||
| <p id="quote"></p> | ||
| <p id="author"></p> | ||
| <button type="button" id="new-quote">New quote</button> |
There was a problem hiding this comment.
minor feedback: it is good UX to always highlight when a button is hovered on. you should look up the css :hover and cursor properties. you can start here: https://stackoverflow.com/questions/8762201/how-to-get-the-cursor-to-change-to-the-hand-when-hovering-a-button-tag
good implementation overall. 👍
Author
There was a problem hiding this comment.
Hi, thanks for the feedback and i have now made the requested changes.
sambabib
added
Reviewed
MansoorM11
added
Needs Review
sambabib
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Briefly explain your PR.
Created function in order for quote generator to work correctly according to set requirements. Also added style to make it look more visually appealing
Questions
Ask any questions you have for your reviewer.