Repository navigation
London | 26-ITP-Sep | Shirin Panahian | Sprint 1 | Complete sprint 1 exercises - #1498
Open
shirinpanahian wants to merge 15 commits into
Open
shirinpanahian wants to merge 15 commits into
shirinpanahian wants to merge 15 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
shirinpanahian
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
shirinpanahian
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Nov 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
Function implementations are all correct. Well done.
-
Regarding the PR description, could you use AI to research what should be included in the "Changelist" section of a PR, then revise your Changelist content accordingly?
Comment on lines
+24
to
+26
| const copy = [...list]; | ||
| const middleIndex = Math.floor(listLength / 2); | ||
| copy.sort((a, b) => a - b); |
Contributor
There was a problem hiding this comment.
Could also use Array.prototype.toSorted().
cjyuan
added
Reviewed
shirinpanahian
added
Needs Review
cjyuan
reviewed
Nov 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
I think one of the functions may not pass the tests you prepared.
Comment on lines
+7
to
+10
| if (newList.includes(item)) { | ||
| continue; | ||
| } | ||
| newList.push(item); |
Contributor
There was a problem hiding this comment.
Note: Could also write
if (!newList.includes(item)) {
newlist.push(item);
}
Author
There was a problem hiding this comment.
thank you , that was good idea👍
Comment on lines
+19
to
+22
| describe("findMax", () => { | ||
| it("given an empty array,returns -Infinity", () => { | ||
| expect(findMax([])).toEqual(-Infinity); | ||
| }); |
Contributor
There was a problem hiding this comment.
Did you ran the test script after you made the changes?
Author
There was a problem hiding this comment.
The issue is fixed, and the tests are now passing.
cjyuan
removed
the
Needs Review
cjyuan
added
the
Reviewed
shirinpanahian
added
Needs Review
cjyuan
reviewed
Nov 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+13
to
+21
| if (arrLength === 0) { | ||
| return -Infinity; | ||
| } | ||
|
|
||
| for (const item of elements) { | ||
| if (maxNum < item) { | ||
| maxNum = item; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Note: The code on lines 12, 17-21 also works for empty array.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1071
Changelist
Changelist
Implemented
dedupe: Removes duplicate elements from an array while preserving the original order and first occurrence of each element. Handles empty arrays and arrays without duplicates.Implemented
findMax: Finds and returns the largest number in an array, with handling for empty arrays, single-element arrays and invalid inputs.Implemented
sumandmean: Added the functions to calculate the sum and arithmetic mean of an array of numbers.Implemented
calculateMedian: Calculates the median of an array of numbers, supporting both odd and even numbers of elements. Includes input validation and error handling.Implemented
describeMedian: Returns a descriptive message containing the calculated median, or an appropriate error message when the median cannot be calculated.Refactored
includes: Updated the implementation to use afor...ofloop.Added and updated tests: Expanded test coverage for normal cases, empty arrays, single-element arrays, duplicate elements and invalid inputs.