Skip to content

London | 26-ITP-Sep | Chandramani Gaire | Sprint 1 | Module-Data-Group - #1495

Open
gaireprakash20-ops wants to merge 16 commits into
CodeYourFuture:mainfrom
gaireprakash20-ops:Sprint-1
Open

London | 26-ITP-Sep | Chandramani Gaire | Sprint 1 | Module-Data-Group#1495
gaireprakash20-ops wants to merge 16 commits into
CodeYourFuture:mainfrom
gaireprakash20-ops:Sprint-1

Conversation

@gaireprakash20-ops

@gaireprakash20-ops gaireprakash20-ops commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1071

Changelist

All Sprint 1 tasks are done: the JavaScript functions are working as intended, and the test suite runs successfully.

@gaireprakash20-ops
pass all the tests for calculateMedian function
48ce8d7
@gaireprakash20-ops
make the function throw an error if the input is not an array of numbers
2b6e822
@gaireprakash20-ops
create the test edges and all the test case passed
8ccb8b0
@gaireprakash20-ops
create a function to sum an array of numbers with input validation
381ec0d
@gaireprakash20-ops
all tests for sum function with various inputs and edge cases
1e00cf0
@gaireprakash20-ops
correct the small typo in the test description for sum function
c85bbff
@gaireprakash20-ops
write the code for the dedupe function.
533cce3
@gaireprakash20-ops
make all the edges cases and acceptance criteria for the dedupe function
8b0d129
@gaireprakash20-ops
make a mean function that calculates the mean of an array of numbers
a77f4b8
@gaireprakash20-ops
make all the edges cases for the calculateMean function
4384693
@gaireprakash20-ops
in describeMedian function i add the try catch block to handle errors…
c6c2e2f 
… when calculating the median
@gaireprakash20-ops
MAKE A text edges that can be used to describe the median of a list o…
d139abc 
…f numbers
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@gaireprakash20-ops gaireprakash20-ops added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 5, 2026
@gaireprakash20-ops gaireprakash20-ops changed the title London | 26-ITP-Sep | Chandramani Gaire | Sprint-1 | Module-Data-Group London | 26-ITP-Sep | Chandramani Gaire | Sprint 1 | Module-Data-Group Nov 5, 2026
@gaireprakash20-ops gaireprakash20-ops added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 5, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 6, 2026
cjyuan
cjyuan reviewed Nov 6, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Function implementations are all correct. Well done.

  • Regarding the PR description, could you use AI to research what should be included in the "Changelist" section of a PR, then revise your Changelist content accordingly?

  • You missed updating a file in the refactor sub-folder.

Comment thread Sprint-1/implement/dedupe.test.js Resolved
Comment thread Sprint-1/implement/mean.test.js

@cjyuan cjyuan Nov 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should calculateMean([Infinity, 0, -Infinity]) return, or how should the function behave?
The same also applies to sum().

@gaireprakash20-ops gaireprakash20-ops Nov 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i should show NaN because when its checked in !number.isNan. its THROWS n error

@cjyuan cjyuan Nov 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what you mean. Could you elaborate?

Comment thread Sprint-1/implement/sum.js Resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 6, 2026
@gaireprakash20-ops gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 7, 2026
@cjyuan

cjyuan commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Could you also address last two items in this comment: #1495 (review) ?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 7, 2026
@gaireprakash20-ops

gaireprakash20-ops commented Nov 8, 2026

Copy link
Copy Markdown
Author

I did both revised your Changelist according to content and updated a file in the refactor sub-folder.

@gaireprakash20-ops gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 8, 2026
@cjyuan

cjyuan commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Did you forget to push your changes to GitHub?

Note: We could see all the changed files in a PR by clicking the "Files changed" tab.
image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2026
@gaireprakash20-ops gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 8, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2026
@cjyuan

cjyuan commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaireprakash20-ops @cjyuan