Repository navigation
Manchester | 26-ITP-Sep | Rahana Suleiman| Sprint 1 | Data Groups Coursework - #1493
Open
rahanasuleiman8-ship-it wants to merge 24 commits into
Open
rahanasuleiman8-ship-it wants to merge 24 commits into
rahanasuleiman8-ship-it wants to merge 24 commits into
Conversation
…value, with error handling for invalid inputs
…and error handling
…r handling for empty arrays
…mpty arrays, negative numbers, decimals, and non-array inputs
…an array of numbers
…negative and decimal numbers
…ty arrays and non-array inputs
…on-number values and no arguments
…for mean calculation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
rahanasuleiman8-ship-it
added
the
Needs Review
hackertainment
added
Review in progress
|
Congratulation, you have completed this PR successfully. Please keep it up. |
hackertainment
added
Complete
Comment on lines
+7
to
+10
| // 2. Handle empty array edge case (sum of empty array is 0) | ||
| if (elements.length === 0) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
This edge case is actually not needed, because in your algorithm below:
- first, line 13 stored
0into total - then, the
forloop will not run due to no item in theelements - as a result, line 21 returns the initial stored
0(which is the same as line 9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1071
Changelist
Completed implementation, error handling, and Jest test suites for the Sprint 1 array utility exercises (dedupe, max, mean, sum, and describe-median), including loop refactoring and edge-case validation.