Repository navigation
Conversation
…containing null,and undefined. test passed
…that checs if list is array or not). test passed
…he original array, test passed
…d +ve number and only -ve number
…ue of the array if they are numbers or not,test passed
…ray, one test failed
MaharitB
added
the
Needs Review
MaharitB
changed the title
hackertainment
added
Review in progress
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
Just need to fix dedupe.test.js and the other comments are for your future reference only. You are almost there and please keep it up. Thank you.
| function dedupe(array) { | ||
| const withOutDup = []; | ||
| for (let i = 0; i < array.length; i++) { | ||
| const itemArray = array[i]; |
There was a problem hiding this comment.
The variable name itemArray may be a bit confusing. Maybe consider arrayItem or even better just item in the future.
Comment on lines
+39
to
+48
| test("when passed an array of duplicate numbers", () => { | ||
| expect(dedupe([1, 1, 2])).toEqual([1, 2]); | ||
| expect(dedupe([1, 1, 2, 2, 2, 3])).toEqual([1, 2, 3]); | ||
| expect(dedupe([1, 1, 1, 3, 3, 4, 4])).toEqual([1, 3, 4]); | ||
| }); | ||
|
|
||
| test("when passed an array of duplicate characters", () => { | ||
| expect(dedupe(["a", "a", "b", "b", "b", "c"])).toEqual(["a", "b", "c"]); | ||
| expect(dedupe(["c", "c", "e", "e", "z", "z"])).toEqual(["c", "e", "z"]); | ||
| }); |
There was a problem hiding this comment.
All these test cases are testing consecutive duplications. How about dedupe([5, 1, 1, 2, 3, 2, 5, 8]) ? Does it return [5, 1, 2, 3, 8] or [1, 3, 2, 5, 8] ? Please add at least one non-consecutive duplication case. Thank you.
Comment on lines
+39
to
+53
| test("returns an error message when given a string of array", () => { | ||
| expect(describeMedian(["banana"])).toEqual( | ||
| "Could not calculate a median:calculateMedian requires an array of numbers" | ||
| ); | ||
| }); | ||
| test("return an error message when given a number", () => { | ||
| expect(describeMedian(123)).toEqual( | ||
| "Could not calculate a median:calculateMedian requires an array of numbers" | ||
| ); | ||
| }); | ||
| test("return an error message when given list of strings of array", () => { | ||
| expect(describeMedian(["one", "two", "three"])).toEqual( | ||
| "Could not calculate a median:calculateMedian requires an array of numbers" | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Well done. Good test cases coverage.
hackertainment
added
Reviewed
…-Groups into coursework/sprint-1
Author
|
Thank you for your helpful advise. I have made the changes as advised. |
MaharitB
added
the
Needs Review
|
Well done to the fixes. Congratulation, you have completed this PR successfully. |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1071
Changelist
I have completed all the tasks from Implementing functions to writing writing tests.
Questions