Repository navigation
London | 26-ITP-Sep | Mahir Shah | Sprint 1 | Data Groups - #1481
Open
MahirShah300 wants to merge 23 commits into
Open
MahirShah300 wants to merge 23 commits into
MahirShah300 wants to merge 23 commits into
Conversation
MahirShah300
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Nov 4, 2026
Comment on lines
+19
to
+21
| sortedElements = elements.toSorted((a, b) => a - b); | ||
|
|
||
| return sortedElements[sortedElements.length - 1]; |
Contributor
There was a problem hiding this comment.
This work.
Suggestion: Explore a more efficient approach to find the largest numbers in an array.
Author
There was a problem hiding this comment.
Used Math.max(...elements) as a more efficient method
Contributor
There was a problem hiding this comment.
Note: Math.max() works well for numbers.
It is equally important to know how to use a loop to find the extreme value within an array without sorting. Do you know how to implement such a loop? (No change required)
cjyuan
added
Reviewed
MahirShah300
removed
the
Reviewed
MahirShah300
added
the
Needs Review
cjyuan
reviewed
Nov 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
Just one more question.
| (currentValue) => | ||
| typeof currentValue === "number" && !Number.isNaN(currentValue) | ||
| (value) => | ||
| typeof value === "number" && !Number.isNaN(value) && Number.isFinite(value) |
Contributor
There was a problem hiding this comment.
Could you find out which of these checks are redundant?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1071
Changelist
Implemented tests and functions.