Skip to content

London | 26-ITP-May | Boualem Larbi Djebbour | Sprint 2 | Book Library #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djebsoft wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-May | Boualem Larbi Djebbour | Sprint 2 | Book Library #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4da0a58
fixing bugs in js code
djebsoft Apr 23, 2026
cea8304
adding more constraints on user inputs
djebsoft May 18, 2026
af7b214
fixed typo
djebsoft May 18, 2026
8beb4f4
updated the code to delete all rows in one operation
djebsoft May 18, 2026
5f3a2a8
removed unecessary assignement to the buttons
djebsoft May 18, 2026
4528c68
made sure the message displays after the operation is successfully co…
djebsoft May 18, 2026
85b6864
matching the upstream
djebsoft May 18, 2026
48e42d3
matching the upstream
djebsoft May 18, 2026
5a494d4
fixed typo
djebsoft May 18, 2026
abdd8ea
fixed the code to insert row into the right element
djebsoft May 18, 2026
56c565f
fixed syntax errors
djebsoft May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library App</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +28,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -65,7 +62,7 @@ <h1>Library</h1>
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="submit()"
/>
</div>
</div>
Expand Down
54 changes: 24 additions & 30 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
Expand All @@ -16,7 +16,6 @@ function populateStorage() {
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

Expand All @@ -28,19 +27,25 @@ const check = document.getElementById("check");
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
const trimmedTitle = title.value.trim();
const trimmedAuthor = author.value.trim();
const pagesInt = parseInt(pages.value, 10);
if (trimmedTitle === "") {
alert("Please enter a title.");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
if (trimmedAuthor === "") {
alert("Please enter an author.");
return false;
}
if (isNaN(pagesInt) || pagesInt <= 0) {
alert("Please enter a valid number of pages");
return false;
}

let book = new Book(trimmedTitle, trimmedAuthor, pagesInt, check.checked);
myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -52,15 +57,11 @@ function Book(title, author, pages, check) {

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
table.tBodies[0].innerHTML = "";
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = table.tBodies[0].insertRow(-1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
Expand All @@ -72,29 +73,22 @@ function render() {

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.innerText = myLibrary[i].check ? "Yes" : "No";

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
let delBut = document.createElement("button");
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delBut.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down