London | 26-ITP-May | Raihan Sharif | Sprint 3 | Programmer Humour#494
Open
RaihanSharif wants to merge 3 commits into
Open
London | 26-ITP-May | Raihan Sharif | Sprint 3 | Programmer Humour#494RaihanSharif wants to merge 3 commits into
RaihanSharif wants to merge 3 commits into
Conversation
RaihanSharif
added
Needs Review
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM - you may want to create the <img> and <p> tags when you get a result, rather than having an empty one and setting it - having empty placeholder elements is a bit messy because if you read the page you may notice them (e.g. the browser takes a little time to decide to render them, a screen-reader may say they're there, etc)
illicitonion
added
Complete
Author
|
Thank you for that feedback. I was actually thinking something similar but I think read a long time ago that doing that might be inefficient. Probably is under some very specific scenarios that are not relevant to this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed. Able to show comic, or error message if fetch fails. Shows fetch JSON in console.