Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 1 | Destructuring exercises#492

Open
RaihanSharif wants to merge 10 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-1-desctructuring
Open

London | 26-ITP-May | Raihan Sharif | Sprint 1 | Destructuring exercises#492
RaihanSharif wants to merge 10 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-1-desctructuring

Conversation

@RaihanSharif
Copy link
Copy Markdown

@RaihanSharif RaihanSharif commented May 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Did all required tasks. In exercise 2, ignore the last function if you just want a minimal working solution.

@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 8, 2026
illicitonion
illicitonion reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works, but a few questions/suggestions about some details :)

Comment thread Sprint-1/destructuring/exercise-1/exercise.js Outdated
Comment thread Sprint-1/destructuring/exercise-2/exercise.js
Comment thread Sprint-1/destructuring/exercise-3/exercise.js Outdated
Comment thread Sprint-1/destructuring/exercise-3/exercise.js Outdated
@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 14, 2026
@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 14, 2026
@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 15, 2026
illicitonion
illicitonion reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One naming thought

Comment thread Sprint-1/destructuring/exercise-3/exercise.js Outdated
@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RaihanSharif @illicitonion