NW | 25-ITP-Sep | Ahmad Hmedan | Sprint 2 | Book Library#360
Closed
AhmadHmedann wants to merge 19 commits intoCodeYourFuture:mainfrom
Closed
NW | 25-ITP-Sep | Ahmad Hmedan | Sprint 2 | Book Library#360AhmadHmedann wants to merge 19 commits intoCodeYourFuture:mainfrom
AhmadHmedann wants to merge 19 commits intoCodeYourFuture:mainfrom
Conversation
fix the wrong typo of variable name (delBtutton) and close brackets for if statement
AhmadHmedann
added
the
Needs Review
cjyuan
reviewed
Dec 16, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…k and add id with event listener instead. Check validated
AhmadHmedann
added
Needs Review
AhmadHmedann
changed the title
cjyuan
reviewed
Dec 18, 2025
debugging/book-library/script.js
Outdated
| const titleValue = titleInput.value.trim(); | ||
| const authorValue = authorInput.value.trim(); | ||
| const pagesValue = Number(pagesInput.value); | ||
| if (!titleValue || !authorValue || !pagesValue || pagesValue < 0) { |
Contributor
There was a problem hiding this comment.
Some invalid "number of pages" could still pass this check.
Comment on lines
78
to
87
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| if (myLibrary[i].check === true) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| changeReadBut.textContent = readStatus; |
Contributor
There was a problem hiding this comment.
This could be a good opportunity to practice using the ? : conditional operator. Can you rewrite the code on lines 81–87 as a single statement?
debugging/book-library/script.js
Outdated
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let row = tableBody.insertRow(); // why (1) not i+1 insert <tr> with four <td> |
Contributor
There was a problem hiding this comment.
It is best practice to declare a variable using const when the variable is not going to be reassigned a value. There are several variables that has this characteristic.
debugging/book-library/script.js
Outdated
| deleteBut.className = "btn btn-warning"; | ||
| deleteBut.textContent = "Delete"; | ||
| deleteBut.addEventListener("click", function () { | ||
| const DeletedTitle = myLibrary[i].title; |
Contributor
There was a problem hiding this comment.
The convention is to start a variable name with a lowercase letter in JS. Names that begin with an uppercase letter are for data type or class (e.g., Array, String, Book).
cjyuan
added
Reviewed
AhmadHmedann
added
Needs Review
Author
|
Thanks for the feedback, it is clear and helpful. |
cjyuan
reviewed
Dec 18, 2025
debugging/book-library/script.js
Outdated
| const titleValue = titleInput.value.trim(); | ||
| const authorValue = authorInput.value.trim(); | ||
| const pagesValue = Number(pagesInput.value); | ||
| if (!titleValue || !authorValue || Number.isFinite(!pagesValue) || pagesValue <= 0) { |
Contributor
There was a problem hiding this comment.
- "Number of pages" probably cannot be this kind of values but this check cannot yet reject these type of numbers.
Comment on lines
78
to
89
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| if (myLibrary[i].check === true) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| readStatus= myLibrary[i].check===true? "yes":"no"; | ||
|
|
||
| changeReadBut.textContent = readStatus; |
Contributor
There was a problem hiding this comment.
Some of the code here is redundant.
Contributor
There was a problem hiding this comment.
There are still some variables that are assigned once declared using let.
cjyuan
added
Reviewed
AhmadHmedann
added
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I fix all bugs
Questions
none