Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library#351
Closed
jakr-s wants to merge 16 commits intoCodeYourFuture:mainfrom
Closed
Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library#351jakr-s wants to merge 16 commits intoCodeYourFuture:mainfrom
jakr-s wants to merge 16 commits intoCodeYourFuture:mainfrom
Conversation
jakr-s
added
the
Needs Review
cjyuan
reviewed
Dec 11, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
jakr-s
force-pushed
the
feature/book-library
branch
from
494bc23 to
7dc7f7a
Compare
jakr-s
added
Needs Review
Author
I've altered the code using this document as reference |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Debugged the app