London | May 2025 | Hendrine Zeraua | Sprint 2 | Book Library

[rarityXtreme]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

This PR updates the My Book Library project to fix bugs and improve code readability.

• Corrected form validation to require title, author, and a positive page number
• Fixed incorrect use of title as author when adding a book
• Fixed broken delete button and read/unread toggle
• Updated DOM rendering to be safer and clearer
• Cleaned up HTML structure and input types
• Removed placeholder table row and used a proper button for submit
• Left CSS as-is since it’s functional and meets current needs

The project now loads initial books, allows adding/removing books, and correctly updates read status.

Questions

Ask any questions you have for your reviewer.

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Sprint -2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Sprint -2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Sprint -2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Data-Flows Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Data-Flows -Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

[rarityXtreme]

@cjyuan
Hi CJ,

I’ve addressed all points as follows:

• Indentation – Fixed indentation in populateStorage() and ensured consistent formatting across the file.
• Input normalization – Trimmed and stored inputs (titleInput, authorInput, pagesInput) in variables and reused them throughout submit() to avoid repeated DOM access and raw input use.
• Validation – Pages are validated as a positive integer before adding a book.
• Efficient table clearing – Replaced the row-by-row deletion loop with table.querySelector("tbody").innerHTML = "" to clear rows in one operation.
• Button IDs – Removed unnecessary id attributes from action buttons to avoid non-unique IDs.
• Delete flow – Changed the delete button handler to delete the book first, then display the alert message to confirm the completed action.

Thanks again for taking the time to review — your suggestions helped improve both performance and code clarity.

[cjyuan]

Changes look good. Well done.