Glasgow | 25-ITP-May | Adiyah Farhan | Sprint 2 | Book-Library-Project#284
Glasgow | 25-ITP-May | Adiyah Farhan | Sprint 2 | Book-Library-Project#284AdiyahFarhan wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
…dd a book and removes a book successfully
AdiyahFarhan
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
AdiyahFarhan
added
Needs Review
|
Your PR's title isn't in the expected format. Please check its title is in the correct format, and update it. Reason: Sprint part (Debugging) doesn't match expected format (example: 'Sprint 2', without quotes) |
1 similar comment
|
Your PR's title isn't in the expected format. Please check its title is in the correct format, and update it. Reason: Sprint part (Debugging) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Thanks @cjyuan for your valuable feedback, it helps me alot in my learning process. I have updated the HTML and JS files as per your feedback. Please have a look on these changes. |
AdiyahFarhan
changed the title
|
Your PR's title isn't in the expected format. Please check its title is in the correct format, and update it. Reason: Sprint part (Data-Flows) doesn't match expected format (example: 'Sprint 2', without quotes) |
AdiyahFarhan
changed the title
|
Your PR's title isn't in the expected format. Please check its title is in the correct format, and update it. Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes) |
AdiyahFarhan
changed the title
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look great! Well done.
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } else { | ||
| readStatus = "Yes"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| readButton.innerText = readStatus; |
There was a problem hiding this comment.
This could be a good opportunity to practice using the ? : conditional operator. Can you rewrite the code on lines 99-105 as a single statement?
cjyuan
added
Complete
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
3 participants
Learners, PR Template
Self checklist
Changelist
Changes has been made to fix the bugs on the website, Now the list of books can be viewed, add a new book and delete the book successfully.
Questions
No