Open
Conversation
knokko
reviewed
Aug 26, 2021
| if(this.isBase64(file)){ | ||
| const newfile = this.dataURItoBlob(file); | ||
| // file = `${URL.createObjectURL(blob)}`; | ||
| const fname = `${this.uuidv4()}.png`; |
There was a problem hiding this comment.
I don't like that .png is hardcoded after the filename. (We might want to add support for non-image files later.)
knokko
reviewed
Aug 26, 2021
| if (this.__fileChanges[name]) { | ||
| const file = this.__fileChanges[name]; | ||
|
|
||
| // debugger; |
knokko
reviewed
Aug 26, 2021
| this.__activeCurrentRelations.includes(name), | ||
| `Field \`${name}\` does not exist on the model.` | ||
| ); | ||
| this.isBase64File = false; |
There was a problem hiding this comment.
Why do we need this? It looks like this value is never read.
Also, I don't believe this variable makes sense: what should it be when the model has both a regular file field and a base64 file field? The current implementation seems to base this decision on just the type of the last file field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling base64 encoded file fields.