Conversation
The new frozen dict actually does not let you just set attributes after creating the dict, just like it is actually frozen :P.
TODO split commits better, docker-compose -> docker compose is not split over 2 commits
PFvanBeerendonk
force-pushed
the
debian_12_support
branch
from
df17d3c to
40651c1
Compare
|
Tried removing --break-system-packages flags, but latest py version complains about it. Tried fixing it with venv, but took too much time to fix (while we are in a container anyways, so it should be fine) |
BBooijLiewes
left a comment
BBooijLiewes
left a comment
There was a problem hiding this comment.
Can you also rebase the commits such that they become one?
.travis.yml
Outdated
| - "3.5" | ||
| - "3.6" | ||
| - "3.7" | ||
| - "3.12" |
There was a problem hiding this comment.
Can you make the test suite test:
- Python 3.7 (deb 10)
- Python 3.9 (deb 11)
- Python 3.11 (deb 12)
Think the others like python < 3.7 and python 3.12 may be a bit overkill for now.
| COPY requirements.txt ./ | ||
|
|
||
| RUN pip3 install -Ur requirements.txt | ||
| RUN pip3 install -Ur requirements.txt --break-system-packages |
There was a problem hiding this comment.
Can you add a comment we do this deliberately?
PFvanBeerendonk
force-pushed
the
debian_12_support
branch
from
40651c1 to
d55aedf
Compare
BlayeeR
left a comment
BlayeeR
left a comment
There was a problem hiding this comment.
Really simple & clean version bump. LGTM
|
Now that I think maybe it would be good to also update |
PFvanBeerendonk
force-pushed
the
debian_12_support
branch
from
d55aedf to
e2b0b45
Compare
BBooijLiewes
left a comment
BBooijLiewes
left a comment
There was a problem hiding this comment.
Also in the setup.py there are install requires:
Line 42 in e2b0b45
can you make sure these match our requirements.txt?
setup.py
Outdated
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: 3.6', |
There was a problem hiding this comment.
Are these ptyhon versions mentioned in setup.py still actually tested? otherwise lets remove them.
Added support for latest debian version.
PFvanBeerendonk
force-pushed
the
debian_12_support
branch
from
e2b0b45 to
62628de
Compare
3 participants
No description provided.