UI/UX, Accessibility & Navigation Remediation (Phases 0-3)#22
Open
syed-reza98 wants to merge 43 commits into
Open
UI/UX, Accessibility & Navigation Remediation (Phases 0-3)#22syed-reza98 wants to merge 43 commits into
syed-reza98 wants to merge 43 commits into
Conversation
Phase 0 (Accessibility): - GestureDetector→InkWell on 8 tappables across social, care, home screens (ClipRRect+Material+InkWell pattern for colored-container ripple) - _IconBtn expanded to 48dp hit target; _ActionBtn height 44→48dp - Double-tap guard in PrimaryPillButton via _isFiring + Future.microtask - app_shell back/pet-switcher pills: history-aware pop + InkWell ripple Phase 1 (Dark-mode color correctness): - AppColors: surface3/3D, warningSoft/D, badge palette (7 colors), premiumGold/Soft - gamified_care_ui: streak/gold gradients, shadows → named tokens - social_profile_screen: avatar ring, stat cards, badge catalog → tokens - cart_screen, activity_screen, settings_screen: 0xFFF2F3F7→surface3, 0xFF2A1820→surface0D, 0xFFF3CD→warningSoft, gold gradient→premiumGold* Phase 3 (Text scaling): - main.dart builder: textScaler.clamp(0.85, 1.3) prevents layout overflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Convert ShellRoute → StatefulShellRoute.indexedStack with 5 branches (global / care / social / matching / marketplace), each with its own navigatorKey; widget trees now survive module switches via IndexedStack - AppShell.child → AppShell.navigationShell (StatefulNavigationShell) - Add PopScope at shell level for correct Android back handling - Remove duplicate /social/notifications shell route (router_notifier already redirects it to /notifications) - Update app_shell_widget_test to use StatefulShellRoute (now passes) - Update stale golden snapshots for light/dark theme panels flutter analyze: 1 pre-existing anonKey info lint flutter test: 115 pass / 2 pre-existing failures (vs 112/5 before) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…gation Restructured all StatefulShellBranch sub-routes from flat siblings to nested children so Android back gesture pops to the branch root instead of exiting the app. - Care: nutrition/health/walk/appointments nested under /care - Social: stories/communities/profile/me nested under /social - Matching: inbox/liked nested under /matching - Global: notifications/activity/me nested under /home (renamed paths from /notifications → /home/notifications etc., updated 5 call sites) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds Semantics(label:, button: true) to every unlabeled GestureDetector tap target across 68 files in lib/features/ so TalkBack (Android) and VoiceOver (iOS) can announce each interactive element. - Filter/toggle chips use selected: + ", selected" suffix pattern - Fixed misaligned Semantics close in social_screen.dart PostCard - story_viewer_screen: pet profile header tap now announces correctly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r feature screens to use custom sliver-based top padding
…oss multiple features and widgets
… and polish header component aesthetics
…petfolio into accessibility-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IconButtons;GestureDetector→InkWellon 8 high-traffic surfaces (social feed, care tiles, hub home); 48dp hit target on_IconBtn; double-tap guard onPrimaryPillButton; form autofill hints on auth/registration fields;Semanticson ProductCard and swipe cards;ExcludeSemanticson decorative paintersColorliterals eliminated via new token families —surface3/3D,warningSoft/D,badge*,premiumGold/Soft; replacements acrossgamified_care_ui,social_profile_screen,cart_screen,activity_screen,settings_screenShellRoute→StatefulShellRoute.indexedStackwith 5 branches (global/care/social/matching/marketplace); each branch has its ownnavigatorKeyso widget trees survive module switches viaIndexedStack;PopScopeat shell level for Android back; removed duplicate/social/notificationsroutetextScalerclamped to[0.85, 1.3]inMaterialApp.routerbuilder to prevent overflow at 200% system text scaleTest plan
flutter analyze— 1 pre-existinganonKeyinfo lint onlyflutter test— 115 pass / 2 pre-existing failures (appointment model + synthetic spring contract)🤖 Generated with Claude Code