Repository navigation
Port the ImageMagick sample to .NET 10 and Magick.NET 15 - #2337
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
Retarget both projects to net10.0, move Magick.NET-Q8-AnyCPU to 15.0.0 and the test packages to xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Add the ImageMagick.Drawing namespace, take uint sizes, cast Width and Height to int, dispose the image with using var, and rename the test class off Live so CI runs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves csharp-images/GenerateImagesInCSharpUsingImageMagick to net10.0 and Magick.NET-Q8-AnyCPU 15.0.0, and the test project to xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Magick.NET 14 moved Drawables into the ImageMagick.Drawing namespace and made sizes uint, so ImageService gains the using directive and takes uint width and height, Program.cs casts image.Width and image.Height to int and disposes the image with using var, and the tests get the same casts. The test class is renamed from ImageMagickLibraryLiveTest to ImageMagickLibraryTests: none of its seven tests touches the network, so CI should run them instead of filtering them out. Built with 0 warnings and 0 errors on SDK 10.0.302, runtime 10.0.10; 7 of 7 tests pass with the CI filter. This also covers the Magick.NET security update proposed in #2237, since 15.0.0 is newer than 14.17.1.