Skip to content

Comments

Enable exploreState without value profile#1037

Merged
oetr merged 2 commits intomainfrom
exploreState-no-value-profile
Feb 23, 2026
Merged

Enable exploreState without value profile#1037
oetr merged 2 commits intomainfrom
exploreState-no-value-profile

Conversation

@kyakdan
Copy link
Member

@kyakdan kyakdan commented Feb 9, 2026

This PR is based on #1036. Thus, it should be reviewed after merging that PR and rebasing on main

Replace the tracePcIndir-based value profiling approach with dedicated
coverage counters via CountersTracker. This removes the dependency on
-use_value_profile=1 and tracks all 256 byte values (up from 128) by
mapping each to a unique (counter, bucket) pair across 32 counters.
@kyakdan kyakdan force-pushed the exploreState-no-value-profile branch from 0011617 to 00abfc4 Compare February 20, 2026 17:30
Copy link
Contributor

@oetr oetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement!

@oetr oetr enabled auto-merge (rebase) February 23, 2026 12:36
@oetr oetr merged commit dd9416b into main Feb 23, 2026
9 checks passed
@oetr oetr deleted the exploreState-no-value-profile branch February 23, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants