Add autocompleteBraces setting to Behavior configuration#365
Open
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Open
Add autocompleteBraces setting to Behavior configuration#365William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
The autocompleteBraces setting existed in CodeEdit's preferences but was never passed through to the source editor. This adds the setting to the Behavior configuration struct and conditionally sets up bracket pair filters based on its value. When autocompleteBraces is false, both the open pair filters and delete pair filters are skipped, preventing automatic insertion of closing brackets. Fixes CodeEditApp/CodeEdit#1691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
autocompleteBracessetting existed in CodeEdit's preferences UI but was never passed through to the source editor, making the toggle completely non-functional.This PR adds the
autocompleteBracesproperty toSourceEditorConfiguration.Behaviorand conditionally sets up bracket pair filters based on its value.Changes
autocompleteBraces: BooltoBehavior(defaults totruefor backward compatibility)setUpTextFormation()to skip open/delete pair filters whenautocompleteBracesisfalsedidSetOnControllerto re-run text formation setup when the setting changesRelated