Add indication for externally deleted files#1999
Add indication for externally deleted files#1999tom-ludwig merged 9 commits intoCodeEditApp:mainfrom pro100filipp:main
Conversation
tom-ludwig
requested review from
austincondiff,
thecoolwinter and
tom-ludwig
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
Looks nice, solid work! 🔥
CodeEdit/Features/Editor/TabBar/Tabs/Tab/Models/EditorTabFileObserver.swift
Outdated
Show resolved
Hide resolved
pro100filipp
dismissed stale reviews from matthijseikelenboom and austincondiff
via
b3d8a48
|
Implemented all suggested changes |
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
Please fix failed tests
|
Sorry for being absent, will fix the pipeline in a few days (though the error seems strange to me) |
|
Just a heads up, we’ve pushed a change, converting all Xcode groups to folders, and made some adjustments to updated SwiftLint a few others. This might impact these issues and I would recommend updating with main before attempting to fix anything. |
|
Fixed errors from the pipeline, could you please approve it again |
|
It looks like there is a small SwiftLint error. Pleas fix it before we move forward. |
My bad, sorry. Fixed it |
|
✅ Approved like it was 1999 🕺 |
tom-ludwig
left a comment
tom-ludwig
left a comment
There was a problem hiding this comment.
Perfect! Thank you very much for your contribution
|
@allcontributors please add @pro100filipp for code |
|
I've put up a pull request to add @pro100filipp! 🎉 |
5 participants
Description
Related Issues
Checklist
Screenshots
1936.mov