Skip to content

Fix Codex 535 root landmark #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaopengbin wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Fix Codex 535 root landmark #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/adapters/codex.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const codex = {
defaultPort: 9335,
lastVerified: {
darwin: { appVersion: "26.707.72221", build: "5307", verifiedAt: "2026-07-16" },
win32: { appVersion: "26.727.6591", build: "535", verifiedAt: "2026-08-01" },
},
rendererProfiles: {
[codexThemeV1Profile.id]: codexThemeV1Profile,
Expand Down Expand Up @@ -39,7 +40,7 @@ const codex = {
// The root landmark is the only blocking check: it doubles as the
// "app finished booting" signal and the minimal app fingerprint. Everything
// else warns — the sidebar collapses, and CSS is inert on absent nodes.
rootAny: ["main.main-surface"],
rootAny: ["main.main-surface", "#root main"],
recommended: [
{ name: "sidebar", any: ["aside.app-shell-left-panel"] },
{ name: "composer", any: [".composer-surface-chrome"] },
Expand Down
7 changes: 6 additions & 1 deletion tests/adapters.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ test("Codex verification keeps only current cross-route landmarks", () => {
build: "5307",
verifiedAt: "2026-07-16",
});
assert.deepEqual(adapter.verification.rootAny, ["main.main-surface"]);
assert.deepEqual(adapter.lastVerified.win32, {
appVersion: "26.727.6591",
build: "535",
verifiedAt: "2026-08-01",
});
assert.deepEqual(adapter.verification.rootAny, ["main.main-surface", "#root main"]);
// Only the root landmark blocks: the sidebar collapses and other panels are
// route-dependent, so every other landmark is warning-level.
assert.equal(adapter.verification.required, undefined);
Expand Down