Admin Bugbash Fixes by Yurika-Kan · Pull Request #209 · Code-4-Community/ssf

Yurika-Kan · 2026-08-12T04:17:36Z

📝 Description

Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
Invalid ?donationId / ?orderId deep links show a "not found" error.
Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
Failed application fetches render an "Unable to Load Applications" error state.
Application Review "View Details" uses navigate() instead of href (SPA transition).
Cognito errors include the AWS reason and re-throw existing HttpExceptions.
Approve Food Manufacturers pagination arrows disable at first/last page.
Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
User Management shows an "Admin" badge on admin rows.
Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
Order Management table wrapped in overflowX="auto".
Removed dev-only "All Pages" nav link.
Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
Admin order table now refreshes auto after allocation edits.

… state

…is deactivated

…l scroll

Copilot

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing `HttpException`s and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

dburkhart07

one other thing: is the test.ico actually needed here?

Prevents "Donation #undefined" header flash during modal close animation.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Yurika-Kan <148014074+Yurika-Kan@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

dburkhart07

see a few slack questions in addition to this.

dburkhart07 · 2026-08-15T19:42:13Z

      {
        index: true,
-        element: <Homepage />,
+        element: <Navigate to={ROUTES.LOGIN} replace />,


We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

jiang-h-y · 2026-08-16T01:43:45Z

@@ -35,8 +35,10 @@ const NewVolunteerModal: React.FC<NewVolunteerModalProps> = ({
  const [isOpen, setIsOpen] = useState(false);


Found a new bug, where the alert state gets stale.

To reproduce:

Open the "Add New User" modal.

Enter a faulty name/email/phone number.

Close the modal.

Open the modal again, and the error message appears without filling in any fields.

Drops password/phone (never used by admin-created users) and adds role directly to the DTO instead of an ad-hoc Omit<> intersection type.

…n cold backend Previously a single failed getMe() call (e.g. backend still starting up) permanently showed "Profile not found", with no recovery short of a manual refresh. Now retries every 3s while the backend is unreachable (no HTTP response), only giving up on a real auth error response.

Closing via backdrop click or the X button left isEditing stuck true, so reopening the modal showed the edit form instead of the details view. Only the Cancel button reset it before. Now onOpenChange resets isEditing whenever the dialog closes, matching Cancel's behavior.

Requested in review for readability now that public/protected routes are interleaved without the old homepage route as a visual anchor.

Standardizes filter UX by adding search-to-filter inputs to adminDonation, approveFoodManufacturers, and approvePantries, matching the existing pattern in pantry/manufacturer management pages.

…ntity Backend rejects edit/delete once a donation has reserved items even while status is still AVAILABLE; mirror that in the details modal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Yurika-Kan · 2026-08-23T18:58:54Z

Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
Trim SignUpDto: adminCreateUser only uses fields it needs now.
Reset isEditing: donation details modal clears edit state on close.
Protected routes marker: comment in app.tsx flags where protected routes start.
Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

Copilot

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

  @IsOptional()
  @IsString()
  @IsPhoneNumber('US', {
    message: 'Secondary phone contact must be a valid US phone number.',
  })

      <OrderDetailsModal
        orderId={selectedOrderId}
        isOpen={selectedOrderId !== null}
        onClose={() => {
          setSelectedOrderId(null);
          navigate(ROUTES.ADMIN_ORDER_MANAGEMENT, { replace: true });
        }}
+        onSuccess={fetchOrders}
      />


Alert state persisted across modal reopens since only isOpen was reset. clearAlert now runs on every close path (X, Cancel, backdrop, success/fail).

Long badge labels (e.g. "Food Manufacturer") could overflow past the card's right edge on narrow cards since the header row never wrapped.

… disappears selectedManufacturers never got reconciled against manufacturerOptions after a refetch, so deleting a manufacturer's last donation left its name stuck in the filter state with no visible checkbox to uncheck it, permanently showing "No donations match the selected filter." Also reset the filter's search text on close so it doesn't show a stale query with no results. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Yurika-Kan · 2026-08-24T03:18:04Z

stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
Filter selection now prunes itself against live options on every refetch
Search box text now clears when filter dropdown closes

…ut safely Address Copilot review comments: fetchOrders was resetting currentPages to 1 on every call, bouncing admin back to page 1 after saving edits in the order details modal. Also type retryTimeout as possibly undefined to match how it's actually assigned.

…bugbash

The accepted Copilot autofix (cc953a8) left the closing tag missing its '>', a JSX syntax error that would fail the build.

dburkhart07

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

jiang-h-y

lgtm! tested that the bugs we surfaced can no longer be reproduced

Yurika-Kan added 16 commits July 25, 2026 18:04

login UI cleaned

501e100

Homepage UI

db39afa

Merge remote-tracking branch 'origin/main' into yk/admin-bugbash

a22c5b6

UI flicker on page load/refresh

186714d

bad deep-link id fix

ddeb91c

donation stats pagination

52174c9

fix API failure on Application Review renders No Applications success…

f64cffa

… state

better user promotion aws language

bfb1d7e

fix Pagination arrows on Approve Food Manufacturers

56e7f6b

fix Pantry assignee cell renders blank when every assigned volunteer …

3e4e762

…is deactivated

User Management lists admins but has no Role label

711c863

Filtering to zero results shows a bare table or wrong copy

104ee89

Order Management table is cut off on narrow windows with no horizonta…

77538f5

…l scroll

remove all pages from navbars

7fc7298

focus trap errors

ea2efd2

Admin order table does not refresh after editing allocations

518b29a

Copilot AI lite review requested due to automatic review settings August 12, 2026 04:17

Copilot started reviewing on behalf of Yurika-Kan August 12, 2026 04:18 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

dburkhart07 requested changes Aug 12, 2026

View reviewed changes

Yurika-Kan added 2 commits August 13, 2026 01:56

cleanup & phone number wording

d6561b2

fix: derive donationId from displayDonation, not donation

d21c358

Prevents "Donation #undefined" header flash during modal close animation.

Yurika-Kan requested a review from jiang-h-y August 14, 2026 22:06

Copilot started work on behalf of Yurika-Kan August 14, 2026 22:10 View session

Yurika-Kan and others added 2 commits August 14, 2026 18:11

fix fontStyle type error

2427faf

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix(frontend): restore href semantics on pantry details link

0e61d39

Co-authored-by: Yurika-Kan <148014074+Yurika-Kan@users.noreply.github.com>

Copilot finished work on behalf of Yurika-Kan August 14, 2026 22:13

Yurika-Kan and others added 3 commits August 14, 2026 18:19

secondary phone num wording

dc06b91

href > onclick

b3a4771

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

phone num wording

08ea5e9

pagination ultimate form

0b21aa3

Yurika-Kan requested a review from dburkhart07 August 14, 2026 23:50

Yurika-Kan added 3 commits August 15, 2026 00:56

double click submit buttons bug

4d67aff

duplicate submit bugs & stale response race bug

05465c2

remove home page

30d87b6

dburkhart07 requested changes Aug 15, 2026

View reviewed changes

jiang-h-y reviewed Aug 16, 2026

View reviewed changes

jiang-h-y mentioned this pull request Aug 18, 2026

Admin Bugbash (small fixes) #210

Closed

Yurika-Kan and others added 6 commits August 23, 2026 13:58

refactor(auth): trim SignUpDto to fields adminCreateUser actually uses

882fb16

Drops password/phone (never used by admin-created users) and adds role directly to the DTO instead of an ad-hoc Omit<> intersection type.

docs(frontend): mark where protected routes start in the router config

0cc731f

Requested in review for readability now that public/protected routes are interleaved without the old homepage route as a visual anchor.

feat(frontend): add search to manufacturer/pantry filter dropdowns

f7fc1cf

Standardizes filter UX by adding search-to-filter inputs to adminDonation, approveFoodManufacturers, and approvePantries, matching the existing pattern in pantry/manufacturer management pages.

fix(frontend): hide donation edit/delete when items have reserved qua…

b4a3fab

…ntity Backend rejects edit/delete once a donation has reserved items even while status is still AVAILABLE; mirror that in the details modal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Yurika-Kan requested review from dburkhart07 and jiang-h-y and a lite review from Copilot August 23, 2026 18:59

Copilot started reviewing on behalf of Yurika-Kan August 23, 2026 19:00 View session

Copilot AI reviewed Aug 23, 2026

View reviewed changes

Yurika-Kan and others added 4 commits August 23, 2026 16:16

fix(frontend): clear stale alert when volunteer modal closes

f30fd84

Alert state persisted across modal reopens since only isOpen was reset. clearAlert now runs on every close path (X, Cancel, backdrop, success/fail).

fix(frontend): let dashboard card badge wrap instead of overflowing card

ac4e425

Long badge labels (e.g. "Food Manufacturer") could overflow past the card's right edge on narrow cards since the header row never wrapped.

Potential fix for pull request finding

cc953a8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Yurika-Kan added 3 commits August 23, 2026 23:55

Merge remote-tracking branch 'origin/yk/admin-bugbash' into yk/admin-…

ee013e4

…bugbash

fix(frontend): close Pagination.NextTrigger tag

73a5343

The accepted Copilot autofix (cc953a8) left the closing tag missing its '>', a JSX syntax error that would fail the build.

dburkhart07 approved these changes Aug 24, 2026

View reviewed changes

jiang-h-y approved these changes Aug 25, 2026

View reviewed changes

		@@ -35,8 +35,10 @@ const NewVolunteerModal: React.FC<NewVolunteerModalProps> = ({
		const [isOpen, setIsOpen] = useState(false);

Uh oh!

Conversation

Yurika-Kan commented Aug 12, 2026

📝 Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

dburkhart07 Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jiang-h-y Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Yurika-Kan commented Aug 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Yurika-Kan commented Aug 24, 2026

Uh oh!

dburkhart07 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiang-h-y left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dburkhart07 left a comment •

edited

Loading