Skip to content

#87 - Frontend Login/Signup Page#91

Open
aaronashby wants to merge 9 commits intomainfrom
aa-frontend-login
Open

#87 - Frontend Login/Signup Page#91
aaronashby wants to merge 9 commits intomainfrom
aa-frontend-login

Conversation

@aaronashby
Copy link
Collaborator

Description

I built out the frontend for logging in and registering a user for the admin dashboard.

Changes Made

  • Backend changes
  • Frontend changes
  • Database schema changes
  • Configuration updates
  • Other

Testing & Verification

  • Unit tests pass
  • Manual testing completed
  • No breaking changes

Verification Steps:

I ensured that the correct input fields show up when a user wants to log in vs. when a user wants to sign up. I also ensured that clicking the "Login" or "Finish Profile" buttons actually send the populated fields to the correct endpoint via console logging.

Screenshots

Login

image image

Signup

Step 1

image image

Step 2

image

Future Improvements/Notes

I didn't implement the confirmation menus (i.e. password reset instructions email sent & successful account creation) in this branch as that is currently being worked on in another ticket.

Related Issues

Closes #87

@aaronashby aaronashby marked this pull request as ready for review March 12, 2026 00:10
Copy link
Collaborator

@thaninbew thaninbew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. On the Login page, the "Create Account" button looks disabled when !email || !password but it is not actually disabled (no disabled prop). This means users can submit empty fields if they click it

  2. Use unique IDs (e.g. password, confirmPassword) and match Label htmlFor. doing it the current way is knwon to cause issues in DOM.

  3. headerText switch has unreachable breaks / missing default returnIn headerText you return ...; break;

  4. Either remove noValidate and let browser validation handle basics, or keep noValidate but enforce validation in handleSubmit / disable submit consistently -- the code sets noValidate on the form, but rely on:

  • pattern + peer invalid styles for email (thats only styling, not blocking submit)
  • visual disabled styles in some places (not always acctual disabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend Login Page + Components

2 participants