Skip to content

[CI] Publish workflow prints signing secrets to the log #123

Open

Description

@gabrielbmoro

Problem

The Android publication workflow echoes the signing key, its password, and the key id into the job log. GitHub masks known secrets, but masking fails for multiline values (such as an armored GPG key) and for any transformed value. There is no reason to print these values. The same workflows also use outdated action versions and do not declare minimal permissions.

Evidence

Proposal

  • Remove the three echo lines.
  • Update actions/checkout and actions/setup-java to v4.
  • Declare minimal permissions: in the workflows (for example contents: read).

Acceptance criteria

  • No workflow prints a secret variable (verifiable with a repository grep).
  • Checkout and setup-java actions use v4.
  • permissions: is declared in the affected workflows.
  • Workflow syntax is validated (actionlint if available, otherwise manual review).
  • Publication behavior is otherwise unchanged.

Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions