ci: harden release workflow against version-input shell injection#4
Merged
Conversation
Pass github.event.inputs.version / steps.ver.outputs.version through env vars
instead of interpolating ${{ }} directly into run: shell blocks (CWE-78). A
workflow_dispatch version like $(...) would otherwise be evaluated by the shell.
matrix.* / with: usages are repo-controlled or not shell-evaluated and unchanged.
Addresses devin-ai-integration PR #3 review.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. Pass the
workflow_dispatchversion input (and the derivedsteps.ver.outputs.version) throughenv:vars and reference$INPUT_VERSION/$VERSIONin shell, instead of interpolating${{ ... }}directly intorun:blocks — closes the script-injection vector (CWE-78) flagged by the PR #3 bot review.matrix.*(repo-controlled) andwith:block uses (not shell-evaluated) are left as-is.YAML validated locally.