Repository navigation
Conversation
Fixed a bug where text-based Git tags
## Fix build artifacts for non-numeric Git tags Update the Clover build scripts to correctly handle both numeric and descriptive Git tags. Previously, the build system assumed that the revision was always numeric and unconditionally added the `r` prefix. This resulted in incorrect artifact and installer version names for descriptive tags, for example: `Clover_rClover-Build-Alpha.pkg` The revision handling is now normalized as follows: * Numeric tags such as `5175` are converted to `r5175`. * Non-numeric tags such as `Clover-Build-Alpha` are used unchanged. * Composite tags such as `Clover_r5200_Clover-Build-Alpha` are also used unchanged. This is applied consistently to: * Clover package names * CloverV2 archives * Clover ISO archives * Installer version information Examples: * `5175` → `Clover_r5175.pkg` * `Clover-Build-Alpha` → `Clover-Build-Alpha.pkg` * `Clover_r5200_Clover-Build-Alpha` → `Clover_r5200_Clover-Build-Alpha.pkg` This preserves the existing naming convention for numeric revisions while allowing descriptive Git tags to be used without generating duplicated or invalid `r` prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where text-based Git tags
Description
Support non-numeric Git tags in build artifacts
Update the Clover build scripts to handle both numeric and descriptive Git tags correctly.
Previously, build scripts always assumed that the revision was numeric and unconditionally added the
rprefix when generating artifact names. This resulted in incorrect names such as:Clover_rClover-Build-Alpha.pkgThe revision handling is now normalized as follows:
5175are converted tor5175.Clover-Build-Alphaare used unchanged.Clover_r5200_Clover-Build-Alphaare also used unchanged.Updated artifact naming examples:
5175→Clover_r5175.pkgClover-Build-Alpha→Clover-Build-Alpha.pkgClover_r5200_Clover-Build-Alpha→Clover_r5200_Clover-Build-Alpha.pkgThe same revision handling is applied consistently to the Clover package, CloverV2 archive, and Clover ISO build scripts.
Type of change
Checklist
Additional information
Include any extra details relevant to your PR.