Repository navigation
The history page shows a code.bisect_candidates call - #669
caseylee-TC wants to merge 3 commits into
Conversation
The section listed the inputs but, unlike code.pr_check, never showed a call. Add one example with a version window and symbols, and say that it needs PR history and that the score ranks candidates without proving a cause. Signed-off-by: Casey Lee <caseylee.techcomm@gmail.com>
|
@caseylee-TC The example's first sentence does not hold in the setup it describes. With merged-PR history and no tracker,
So the snippet, run as described, ranks the PRs of the last 90 days that touched the function's files, not the PRs between the two releases. Either of these would fix it:
The rest of the section (the score ranks candidates without proving a cause) is right. |
With merged-PR history and no tracker, bad_version and good_version do not bound the scan; the op reads the last LOOM_CODE_BISECT_HISTORY_DAYS. Say so, and say the version window needs a linked tracker. Signed-off-by: Casey Lee <caseylee.techcomm@gmail.com>
|
Thanks @zlareb1, that's a good catch. I checked it against I went with your option 1. In 4dcafc4 the paragraph above the example now says the version I haven't run the example against a live server, and I haven't verified the release-label |
|
Thanks, the fix is right except for one phrase, and that one came from my comment: "PRs carry release labels" is not accurate. The tracker scan does not read GitHub labels. It matches each PR record's
With that change it can merge. |
Closes: #633
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Not required for a documentation change.
Why
The "Bisect candidates" section of the history page listed the inputs of
code.bisect_candidatesbut, unlikecode.pr_check, showed no call. This adds one example with a version window andsymbolsthat prints each candidate's PR number and score. It says the op needs merged-PR history and that the score ranks candidates without proving a cause.Scope and risk
One docs page, about 24 added lines. No code, settings or generated files change. The example sits after the numbered steps so those steps stay together.
Compatibility, rollout and rollback
Tests
make lintandmake typecheckpass.make format-check, the two pytest files (240 passed) anddocs_reference --checkpass, as listed in the issue.symbols,bad_version,good_version,candidates,pr_number,score) matchdocs/reference/operations/code.md. The input and output names are also confirmed inCodeBisectCandidatesInputandCodeBisectCandidatesOutput.mkdocs build --strictpasses and the rendered page looks right (screenshot attached).UploadClient.sendfollows the dotted style of thecode.pr_checkexample; another page uses::, so I'm happy to change it.server/code/app/bisect_scan.pyand with athrowaway test: with
bad_version/good_versionand no tracker, the plan clears the timewindow, and the PR-history read covers the last
LOOM_CODE_BISECT_HISTORY_DAYS(90 by default)AI assistance in the code (leave one; writing this description with AI is fine):
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed. (docs-only change.make format-check,make lintandmake typecheckpass, as do the doc-link and public-copy tests and the docs reference check. I stopped make test-unit locally before it finished; CI runs the full unit suite.)docs/reference/configuration.mdand thedocs/reference/tables (python scripts/codegen/docs_reference.py), the reach manifest,schemas/schema.sql(make schema-dump) and the Codex plugin copies (python3 scripts/codegen/agent_plugin_sync.py). (not applicable: docs only)main; no merged migration is edited. (not applicable: docs only)hooks/,lib/,bin/,skills/,.mcp.json, the Codexplugin-defaults.json) bumps both plugin manifests' version, and no other open PR uses that version. (not applicable: docs only)npm --prefix frontend run build) and its tests pass, iffrontend/changed. (not applicable: docs only)docs/describe the system as it now is, and this description names any operator steps and wire changes.tests/unit/test_public_copy.py).git commit -s), as CONTRIBUTING.md asks.