Skip to content

Preserve Kafka setting during ClickPipe updates - #418

Merged
sdairs merged 2 commits into
issue-296-typed-openapi-enumsfrom
fix-clickpipe-kafka-read-committed
Aug 18, 2026
Merged

Preserve Kafka setting during ClickPipe updates#418
sdairs merged 2 commits into
issue-296-typed-openapi-enumsfrom
fix-clickpipe-kafka-read-committed

Conversation

@sdairs

@sdairs sdairs commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the current kafka_read_committed value when updating unrelated ClickPipe settings
  • fail instead of fabricating a value when the tolerant settings response omits the required field
  • add subprocess and wiremock coverage for the settings GET to PUT request flow

Verification

  • cargo test -p clickhousectl
  • cargo clippy -p clickhousectl --all-targets -- -D warnings
  • cargo fmt --all --check

@sdairs sdairs changed the title fix clickpipe kafka read committed Preserve Kafka setting during ClickPipe updates Aug 14, 2026
Comment thread crates/clickhousectl/src/cloud/clickpipes.rs Outdated
@sdairs
sdairs requested a lite review from Copilot August 17, 2026 11:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sdairs
sdairs force-pushed the fix-clickpipe-kafka-read-committed branch from e15dd4a to 727e7ca Compare August 17, 2026 11:25
Comment thread crates/clickhousectl/src/cloud/clickpipes.rs
@sdairs
sdairs force-pushed the fix-clickpipe-kafka-read-committed branch from 727e7ca to 0c46eaf Compare August 18, 2026 14:58
@sdairs
sdairs merged commit a9da118 into main Aug 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants