Cover query endpoint GET + DELETE in service suite#172
Open
sdairs wants to merge 1 commit into
Open
Conversation
Adds a GET-after-upsert assertion (roles, openApiKeys, allowedOrigins match what we sent) and a DELETE step ordered before the API key deletion so we can distinguish binding cleanup working from the API key being gone. CleanupRegistry now tracks query endpoint bindings and drops them before API keys for the same reason on the failure path. Closes #158.
sdairs
force-pushed
the
issue-158-query-endpoint-coverage
branch
from
e6cb746 to
ad7011b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instance_query_endpoint_getstep after the upsert that asserts the binding stored matches what we sent (id, roles, openApiKeys, allowedOrigins).instance_query_endpoint_deletestep before the API key delete, followed by a GET that must return 4xx — so the test can distinguish binding cleanup working from the API key being gone.CleanupRegistrywith a query endpoint slot that is cleaned up before API keys on the failure path, preserving the same ordering invariant on panic/early-exit.Closes #158.
Test plan
cargo build -p clickhouse-cloud-apicargo test -p clickhouse-cloud-api(live tests remain#[ignore]; non-live suite passes)cloud_service_crud_lifecyclerun in CI exercises the new GET + DELETE steps end-to-end