feat(Flags): add Malaysia and Taiwan, standardize rounded corners#1030
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Standardizes the rounded-corner approach on flags that were missing it or doing it via custom path geometry. All flags now use a clipPath rect with rx=1, matching the existing pattern in Mexico, Taiwan, and Malaysia. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds a dedicated Storybook page for Flag mirroring the Logo story, and moves Icon and Logo from Display/* to Assets/* so the three asset components are grouped together. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-go7fryuml-clickhouse.vercel.app Built from commit: |
guykoh
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clipPathrect withrx=1, matching the existing pattern.FlagStorybook page (mirroring theLogostory), and movesIconandLogofromDisplay/*toAssets/*so the three asset stories are grouped together.Test plan
Assets/Flag— verify the new playground renders Malaysia, Taiwan, and US flags correctly.Assets/Icon→ "Icons" story — verify the Flags section shows all flags with consistent rounded corners (no square-cornered outliers).Assets/LogoandAssets/Iconappear under the newAssetsgroup in the sidebar (no leftoverDisplay/*entries for these).🤖 Generated with Claude Code