Conversation
The -app suffix was hardcoded on the HyperDX Deployment and Service names, so fullnameOverride could never give full control over naming. Add a clickstack.hyperdx.fullname helper that omits the -app suffix when fullnameOverride is set, while keeping it for the default case to preserve backward compatibility. Made-with: Cursor
🦋 Changeset detectedLatest commit: 58178af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Made-with: Cursor
wrn14897
approved these changes
Mar 27, 2026
dhable
deleted the
hdx-3850-public-helm-chart-should-remove-the-hard-coded-suffix-on-the
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickstack.hyperdx.fullnamehelper template that omits the-appsuffix whenfullnameOverrideis set, giving users full control over resource namingfullnameOverride) is unchanged -- the-appsuffix is still appended for backward compatibility-appto use the new helperCloses HDX-3850
Test plan
helm templatefullnameOverrideproduces name without-appfullnameOverridetest updated to expect name without-appMade with Cursor