Validate benchmark result shapes#953
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
[1.511,1.385,1,440]is now[1.511,1.385,1.440].validate-results.pyfor the main ClickBench result layout. Active dashboard entries now fail validation if their result matrix is not 43 queries x 3 runs, or if timings are not numbers/null. Historical and inactive shape issues are reported as warnings.main.Why
Plain JSON parsing accepts rows like
[1.511,1.385,1,440], but the dashboard expects three timings per query. That can make hot-run comparisons pick a fake1.000second timing instead of the intended1.440second timing.Validation
python3 -B validate-results.pypython3 -B validate-results.py /Users/hoangvu/Code/OSS/ClickBenchjq -e '(.result | length) == 43 and all(.result[]; type == "array" and length == 3 and all(.[]; . == null or type == "number"))' snowflake/results/20220701/l.json pandas/results/20260218/c6a.metal.json\n\nThe validator currently exits 0 and reports warnings for pre-existing historical or inactive files.