Skip to content

Conversation

@strubium
Copy link
Contributor

@strubium strubium commented Oct 8, 2024

No description provided.

@Ecdcaeb
Copy link
Contributor

Ecdcaeb commented Oct 18, 2024

ForgeHooks might be a internal API. what's the purpose?

@strubium strubium marked this pull request as ready for review October 12, 2025 18:51
@strubium strubium changed the title Javadoc for the very helpful files isLivingOnLadder Javadoc Oct 12, 2025
@Desoroxxx
Copy link
Contributor

ForgeHooks might be a internal API. what's the purpose?

It's a public method, doesn't look very internal, and pretty useful

*
* Checks if the block at the current position is a ladder or checks
* multiple block positions within the entity's bounding box if
* {@code fullBoundingBoxLadders} is enabled. If the entity is a spectator it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to ForgeModContainer.fullBoundingBoxLadders explicitly

* Checks if the block at the current position is a ladder or checks
* multiple block positions within the entity's bounding box if
* {@code fullBoundingBoxLadders} is enabled. If the entity is a spectator it
* will return false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the statement If the entity is a spectator it will return false to the @return tag as that is what its for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants