Closed
Conversation
WaitingIdly
requested changes
Mar 20, 2024
Collaborator
WaitingIdly
left a comment
There was a problem hiding this comment.
problems:
- similar logic should also apply to questlines
- since the questID is absurdly long now, should change
PanelButtonQuest.java:103to not display the questID, regardless of if advancedInfo is enabled - again, absurdly long so it should be less publicly visible, should change
EventHandler.java:142so sharing the quest to chat doesnt include the questID. - really long, want an easy way to copy -
GuiQuestLines.java:354is the place where we get the popup for "Share to Chat", should add an option below that for "Copy ID" which copies the quest ID to the clipboard
question:
what is the logic that leads to continuing to use an int instead of switching to using a UUID, as was done in GTNewHorizons#89?
Author
I won't apply this change to quest-line ID and other IDs until #103 is merged.
I think the only advantage of UUID is their randomness. |
Merged
Member
|
Closing in favour of #113. Thank you for all the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now newly created quest ID will be random.
This prevents merge conflicts when multiple people try to add or remove quests simultaneously.
Changing the type of quest ID from int to UUID is pending for compatibility.
I won't apply this change to quest-line ID and other IDs until #103 is merged.