Repository navigation
test(e2e): org logos use their stored S3/CloudFront URL (ParakhAI-frontend#470) - #26
Draft
saqibmanan wants to merge 2 commits into
Draft
saqibmanan wants to merge 2 commits into
saqibmanan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ParakhAI-frontend#470 (merged to dev 2026-11-04) stops building org logo URLs as
NEXT_PUBLIC_DATASPACE_API_URL + logoUrl. Logos are now absolute S3/CloudFront URLs, and they are rendered through a newMediaImage(viamediaUrl()), which falls back to the ParakhAI logo when a load fails.Test added
tests/e2e/test_ai_maker_dashboard.py::TestOrgCardLogos::test_org_card_logos_load_from_their_own_url(markerse2e,regression,auth):Reads the account's orgs with
myOrganizations { name logoUrl }. On dev, 50 have an absolute logo URL.Asserts that each of those orgs' card on
/dashboard/ai-makerrenders<img src>equal to the stored URL.That one check catches both failure modes:
MediaImage's fallbackA plain "image loaded" check would pass in the second case, because the fallback image loads fine.
New code follows the three-layer layout:
AIMakerLocators.ORG_CARD_LOGOAIMakerPage.org_card_logos()Validation on dev (2026-11-06)
1 passed.MediaImagefalls back: