fix: add branded 404 page and fix mobile menu accessible name - #442
Open
anishkb-dev wants to merge 1 commit into
Open
fix: add branded 404 page and fix mobile menu accessible name#442anishkb-dev wants to merge 1 commit into
anishkb-dev wants to merge 1 commit into
Conversation
anishkb-dev
force-pushed
the
fix/404-page-and-mobile-menu-a11y
branch
from
August 8, 2026 07:45
189a5fb to
24db653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/not-found.tsx: a branded 404 page (logo, message, home link, shared nav/footer) replacing the bare default Next.js 404.Sheet.Content(opub-ui) only renders aDialogTitlewhen atitleprop is passed, so Radix's auto-generatedaria-labelledbywas pointing at an element that never rendered. Passingtitle="Navigation menu"renders the (visually-hidden)DialogTitlethe dialog needs.Fixes #368
Fixes #361 (accessible-name part only — the "add nav links to mobile menu" part duplicates #367, which a maintainer already deprioritized: "Mobile usage is not the priority right now")
Test plan
npx tsc --noEmitpasses with no new errors