Repository navigation
ci(deploy): pass STORAGE_PUBLIC_BASE_URL to the build - #518
Open
saqibmanan wants to merge 1 commit into
Open
saqibmanan wants to merge 1 commit into
saqibmanan wants to merge 1 commit into
Conversation
next.config.mjs adds this host to images.remotePatterns at build time (#514). The deploy never set it, so the CloudFront host was never allowed.
saqibmanan
temporarily deployed
to
development
November 4, 2026 07:30 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #514.
next.config.mjsreadsSTORAGE_PUBLIC_BASE_URLat build time to add the CloudFront host toimages.remotePatterns, but the deploy workflow never passed it, so deployed builds didn't allow the CDN host. Nothing breaks today becauseMediaImageis unoptimized, but a plainnext/imagewith a CDN URL would throw.developmentenvironment variable is set:https://d19fu942vtibly.cloudfront.netproductionis left unset until prod moves to S3. Unset means no CDN entry, which is the same as today.