Repository navigation
ci(scan-leaks): scan pull requests from every author - #142
Merged
Merged
Conversation
The gveappsupport machine account no longer opens pull requests here; its publish workflow was removed in #121. Drop its exemption so TruffleHog scans every pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gveappsupportexemption from the TruffleHog job in.github/workflows/scan-leaks.yml, so every pull request gets a secret scan.gveappsupportwas the machine account for the npm publish workflow, which was removed in refactor: prep for Turborepo #121. It hasn't committed here since June 2022, so the exemption only left a gap in scanning.NPM_ACCESS_TOKENandGVE_APP_SUPPORT_ACCESS_TOKEN, have been revoked and deleted from the repository settings. No current workflow references any secret.Test plan
Scan for leakscheck runs on this pull request and passes.