Skip to content

Linutil Debloat#1214

Closed
Abs313a wants to merge 5 commits intoChrisTitusTech:mainfrom
Abs313a:debloat
Closed

Linutil Debloat#1214
Abs313a wants to merge 5 commits intoChrisTitusTech:mainfrom
Abs313a:debloat

Conversation

@Abs313a
Copy link
Copy Markdown
Contributor

@Abs313a Abs313a commented Feb 24, 2026

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Summary

This PR performs a focused debloat pass across Linutil shell scripts and related TUI behavior, reducing duplicated code while preserving functionality and UX.

What Changed

1) Mechanical shell cleanup (P1)

  • Removed redundant checkEscalationTool calls where checkEnv already sets escalation.
  • Removed duplicate common-script.sh sourcing in monitor-control scripts that already source shared utilities.
  • Normalized mismatched menu prompt ranges where applicable.

2) Monitor-control cleanup (P2)

  • Removed duplicate local confirm_action implementation and reused shared helper.
  • Simplified set_resolutions.sh indexing/temp-file flow while preserving behavior.

3) Shared install/uninstall menu abstraction (P3)

  • Added shared helper in core/tabs/common-script.sh:
    • run_install_uninstall_menu
  • Migrated repetitive 2-option install/uninstall main() menus across emulator and design-tool scripts to the shared helper.
  • Left retroarch.sh unchanged because it uses a custom multi-option flow.

4) Abort UX improvement

  • Added (Abort) to shared install/uninstall menu.
  • Abort now exits with code 130 (instead of success 0).
  • TUI now auto-closes command window on abort exit code and returns directly to list view, avoiding misleading success styling.

5) Docs update

  • Updated README.md to document shared script menu behavior (Install, Uninstall, Abort).

Impact

  • Significant reduction of duplicated shell boilerplate across scripts.
  • Cleaner shared behavior for menu handling.
  • Better UX for cancel/abort path.
  • No intended functional regressions in install/uninstall logic.

Issues / other PRs related

.

Screenshots (if applicable)

.

@Abs313a
Copy link
Copy Markdown
Contributor Author

Abs313a commented Feb 24, 2026

@ChrisTitusTech pre-review glance..

@Abs313a Abs313a marked this pull request as ready for review March 10, 2026 12:33
@Abs313a Abs313a requested a review from ChrisTitusTech as a code owner March 10, 2026 12:33
@technicks89
Copy link
Copy Markdown
Contributor

Since checkEnv also contains checkAURHelper, does it make sense to remove those lines as well for the de-bloat?

@Abs313a
Copy link
Copy Markdown
Contributor Author

Abs313a commented Mar 24, 2026

Well spotted, i'll run a complete review of this PR before i raise it again..

@Abs313a Abs313a closed this Mar 24, 2026
@Abs313a Abs313a deleted the debloat branch March 24, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants