Skip to content

fixed github-raw-file-plus copy feature - #359

Merged
ChinaGodMan merged 1 commit into
ChinaGodMan:mainfrom
paponius:github-raw-file-plus
Oct 21, 2026
Merged

ChinaGodMan merged 1 commit into
ChinaGodMan:mainfrom
paponius:github-raw-file-plus

Conversation

@paponius

@paponius paponius commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

变更内容

请简要描述本次提交的变更内容(修复了什么问题、增加了什么功能等)。

fixed github-raw-file-plus copy feature

相关问题

请列出本次 PR 相关的 issue 编号(例如:#123)。

I did not see an Issue filed on GitHub, though there is one on
https://greasyfork.org/en/scripts/505501-github-copy-raw-file-url-and-download-file/discussions/325923

变更类型

  • [X ] 修复 Bug
  • 新功能
  • 代码优化
  • 文档更新
  • 其他(请描述)
  • QA

测试情况

请描述本次提交的变更是否经过测试,以及测试的方式和结果。

tested lightly. Firefox.

注意事项

是否有需要注意的内容或潜在问题(例如,兼容性、依赖项等)?

The cause of the issue:
The clipboard-copy custom element provided natively by GitHub requires a valid for attribute pointing to a target element containing the text, or proper internal value bindings that GitHub's web components library listens to. Since the script injects these elements outside of GitHub's native registration flow, the click handler on the copy button fails.

Also added a feedback, a text showing after the button is clicked.

Recommendations:
The name and description of the script:

// @name:en GitHub Raw File URL Copy & Download
// @description:en Adds buttons to copy raw file URLs and download files directly on GitHub.

While the current EN is somewhat understandable, it leads to further weirdness when translated to other languages.
I do understand few of those used in meta of the script and I can see the translations do not make sense at all.
I checked translate.google.com using the EN I proposed above and it translates to a reasonable degree to other languages.

@ChinaGodBot

Copy link
Copy Markdown
Collaborator

@paponius 你好,人民的勤务员将尽快审查合并此次请求!🚀 [自动回复,请勿跟帖]

@ChinaGodMan

Copy link
Copy Markdown
Owner

thanks☺️

@ChinaGodMan
ChinaGodMan merged commit c8fc0a3 into ChinaGodMan:main Oct 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants