AST-165915: stop forcing linux/amd64 on every container image - #53
Merged
Merged
Conversation
Resolve passed a literal "linux/amd64" to AnalyzeImagesWithPlatform. Every image was therefore matched against amd64 regardless of the host or of the image itself, so any single-architecture image built for another architecture (for example a locally built linux/arm64 image on an ARM64 CI runner) failed to resolve. Nothing here needs a specific architecture, so go back to AnalyzeImages and let each image be resolved on the platform it was actually built for. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
New Issues (9)
Checkmarx found the following issues in this Pull Request
Fixed Issues (9)
Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
Also bumps the containerd/containerd/v2 replace pin to v2.2.1 since the new extractor version requires runtime-spec v1.3.0, which is incompatible with the previously pinned containerd v2.1.5.
cx-dmitri-rivin
marked this pull request as ready for review
September 3, 2026 08:41
Fixes zizmor findings surfaced by the "Scan for GitHub Actions issues" check: adds concurrency groups, disables credential persistence on checkout, and replaces inline template expressions in run: blocks with env vars to close the template-injection findings in pr-name-validation.yml. Replaces release.yml (auto-tag on PR merge) with Hooks-Release.yml, a workflow_dispatch release that builds/vets/tests before tagging and uses the step-security forks of github-tag-action and action-gh-release, mirroring the pattern adopted in Checkmarx/containers-syft-packages-extractor PR #39 and #40 for the same ticket.
cx-adar-zandberg
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve passed a literal "linux/amd64" to AnalyzeImagesWithPlatform. Every image was therefore matched against amd64 regardless of the host or of the image itself, so any single-architecture image built for another architecture (for example a locally built linux/arm64 image on an ARM64 CI runner) failed to resolve.
Nothing here needs a specific architecture, so go back to AnalyzeImages and let each image be resolved on the platform it was actually built for.